Skip to content

Fix/spelling typos 1498#1623

Open
engineer-scientist wants to merge 10 commits into
MFlowCode:masterfrom
engineer-scientist:fix/spelling-typos-1498
Open

Fix/spelling typos 1498#1623
engineer-scientist wants to merge 10 commits into
MFlowCode:masterfrom
engineer-scientist:fix/spelling-typos-1498

Conversation

@engineer-scientist

@engineer-scientist engineer-scientist commented Jul 1, 2026

Copy link
Copy Markdown

Description

Corrects the misspelled identifiers across the codebase. All are fixed here:

  • HardcodedDellacationHardcodedDeallocation (src/common/include/ExtrusionHardcodedIC.fpp, src/pre_process/m_icpp_patches.fpp)
  • tangentaltangential (src/simulation/m_collisions.fpp)
  • fite_path_destfile_path_dest (toolchain/mfc/test/case.py)
  • lblB (src/common/m_finite_differences.fpp)

The following is now obsolete because the upstream code now supersedes it:

  • BC_SlIP_WALLBC_SLIP_WALL (src/common/m_boundary_common.fpp)

Also fixes the following documentation typo that was blocking CI for everyone:

  • patche(s)patch(es) (docs/documentation/case.md)

Closes #1498.

Type of change

  • Other (spelling / identifier typo fixes)

Testing

Verified zero remaining occurrences of all old spellings using:
grep -rn "HardcodedDellacation" src/
grep -rn "tangental" src/
grep -rn "fite_path_dest" src/

No logic changes, purely identifier renames. No new tests added as this is a cosmetic fix with no behavioral change.

Checklist

  • I added or updated tests for new behavior
  • I updated documentation if user-facing behavior changed
GPU changes (expand if you modified src/simulation/)
  • GPU results match CPU results
  • Tested on NVIDIA GPU or AMD GPU

@engineer-scientist

Copy link
Copy Markdown
Author

@claude full review

@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.43%. Comparing base (66254db) to head (c6a375a).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/simulation/m_collisions.fpp 0.00% 13 Missing ⚠️
src/pre_process/m_icpp_patches.fpp 0.00% 12 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1623   +/-   ##
=======================================
  Coverage   60.43%   60.43%           
=======================================
  Files          83       83           
  Lines       19868    19868           
  Branches     2956     2956           
=======================================
  Hits        12007    12007           
  Misses       5860     5860           
  Partials     2001     2001           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbryngelson sbryngelson marked this pull request as draft July 2, 2026 13:58
@engineer-scientist engineer-scientist marked this pull request as ready for review July 2, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Fix internal spelling typos (HardcodedDellacation, BC_SlIP_WALL, tangental, fite_path_dest, lb)

1 participant