Refactor and unify common routines for boundary conditions#1629
Draft
wilfonba wants to merge 2 commits into
Draft
Refactor and unify common routines for boundary conditions#1629wilfonba wants to merge 2 commits into
wilfonba wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR reorganizes and refactors code that was misplaced by agentic coding. The buffer exchange routines for variable buffers, surface tension, F_igr, and grid variables have been unified under a common abstraction. Relevant "boundary primitives" were moved into the
src/common/m_boundary_primitives.fppmodule. As a result of this refactor,src/common/m_boundary_io.fpponly contains routines relevant to boundary condition IO.Closes #(issue number).
Type of change (delete unused ones)
Testing
Checklist
See the developer guide for full coding standards.
GPU changes (expand if you modified
src/simulation/)AI code reviews
Reviews are not retriggered automatically. To request a review, comment on the PR:
@claude full review— Claude full review (also triggers on PR open/reopen/ready)claude-full-review— Claude full review via label