Skip to content

Add /files endpoint and entry type#1414

Merged
ml-evs merged 20 commits into
mainfrom
add_files_endpoint
Jun 30, 2026
Merged

Add /files endpoint and entry type#1414
ml-evs merged 20 commits into
mainfrom
add_files_endpoint

Conversation

@ml-evs

@ml-evs ml-evs commented Dec 6, 2022

Copy link
Copy Markdown
Member

Building from @JPBergsma's work, this PR adds the files endpoint and entry type.

This should not be merged until we have decided if we can support multiple OPTIMADE versions from a single optimade-python-tools version, but in the meantime, this can be used to generate the OpenAPI schemata for v1.2.

To-do:

  • models
  • server code
  • OpenAPI schemas
  • Testing
  • Docs updates

@ml-evs ml-evs added schema Concerns the schema models server Issues pertaining to the example server implementation models For issues related to the pydantic models directly OPTIMADE v1.2 This label describes actions that have to be taken to be complient with OPTIMADE 1.2 labels Dec 6, 2022
@ml-evs ml-evs changed the title Add files endpoint Add /files endpoint and entry type Dec 6, 2022
@ml-evs ml-evs added this to the OPTIMADE v1.2 milestone Dec 6, 2022
@ml-evs ml-evs added the on-hold For PRs/issues that are on-hold for an unspecified time label Dec 6, 2022
@ml-evs ml-evs force-pushed the add_files_endpoint branch from 4b8195b to ff2db52 Compare August 26, 2024 13:09
@ml-evs ml-evs force-pushed the add_files_endpoint branch from 1297b7a to ad62a1f Compare June 30, 2026 07:37
@ml-evs ml-evs marked this pull request as ready for review June 30, 2026 10:27
@ml-evs ml-evs requested a review from CasperWA as a code owner June 30, 2026 10:27
@ml-evs ml-evs removed the on-hold For PRs/issues that are on-hold for an unspecified time label Jun 30, 2026
@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.30%. Comparing base (a2e25af) to head (71a5d05).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1414      +/-   ##
==========================================
+ Coverage   90.16%   90.30%   +0.14%     
==========================================
  Files          75       78       +3     
  Lines        5033     5086      +53     
==========================================
+ Hits         4538     4593      +55     
+ Misses        495      493       -2     
Flag Coverage Δ
project 90.30% <100.00%> (+0.14%) ⬆️
validator 90.30% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ml-evs ml-evs merged commit 688021b into main Jun 30, 2026
13 checks passed
@ml-evs ml-evs deleted the add_files_endpoint branch June 30, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

models For issues related to the pydantic models directly OPTIMADE v1.2 This label describes actions that have to be taken to be complient with OPTIMADE 1.2 schema Concerns the schema models server Issues pertaining to the example server implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants