Skip to content

the value of ref in JSON escapes backslashes.#818

Merged
JeromeMartinez merged 1 commit into
MediaArea:masterfrom
henryborchers:escape-backslashes-in-json
Jun 15, 2026
Merged

the value of ref in JSON escapes backslashes.#818
JeromeMartinez merged 1 commit into
MediaArea:masterfrom
henryborchers:escape-backslashes-in-json

Conversation

@henryborchers

Copy link
Copy Markdown
Contributor

When using a Windows machine, the backslash file paths make json exports invalid json format in "ref"

@henryborchers

Copy link
Copy Markdown
Contributor Author

This looks like there is a file generation part in this that turns Source/Resource/displays/MediaConchJson.xsl into Source/Common/generated/ImplementationReportDisplayJsonXsl.h.

I'm not sure what is being done here.

@henryborchers

henryborchers commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

The Unix tests seem to be failing for reasons that are not related to these changes.

on the Mac test, libevent doesn't look like it's installed and it's expecting it to be.
on the Linux test, it seems like it gets farther but seems to fail test_mk.sh, which is not part of the repo.

Edit: I found it in Project/GNU/CLI/test/test_mk.sh. But the failure still seems unrelated to my changes

@JeromeMartinez

Copy link
Copy Markdown
Member

The Unix tests seem to be failing for reasons that are not related to these changes.

@henryborchers please rebase.

When using a Windows machine, the backslash file paths make json exports invalid json format in "ref"
@henryborchers henryborchers force-pushed the escape-backslashes-in-json branch from 8ae411d to fee7135 Compare June 15, 2026 13:04
@henryborchers

Copy link
Copy Markdown
Contributor Author

@JeromeMartinez oops. I thought I

The Unix tests seem to be failing for reasons that are not related to these changes.

@henryborchers please rebase.

I thought I did. Good catch!

Fixed.

@JeromeMartinez JeromeMartinez merged commit fc7fdad into MediaArea:master Jun 15, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants