feat: Scope skeleton compact-detail to project_id context#4
Open
afonsobspinto wants to merge 1 commit into
Open
feat: Scope skeleton compact-detail to project_id context#4afonsobspinto wants to merge 1 commit into
afonsobspinto wants to merge 1 commit into
Conversation
afonsobspinto
force-pushed
the
feature/NA-894
branch
from
f8698ae to
c44a664
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://metacell.atlassian.net/browse/NA-894
Scopes CATMAID skeleton compact-detail requests to the project in the URL. It adds a shared
validate_skeleton_in_project()helper and applies it to the single skeleton compact-detail endpoint, so a skeleton ID from another project is treated as missing and returns 404 instead of leaking compact skeleton data.Adds regression coverage using skeleton 373, verifying that the correct project still works while requesting the same skeleton through project 5 fails for the compact-detail endpoint.