Add skip for MRPC comp events in ISR loop#132
Open
BenReed161 wants to merge 1 commit into
Open
Conversation
Current implementation just skips the MRPC_COMP, it should also skip the TWI and CLI MRPC completions + ASYNC completion events too. The kernel ISR mask_event incorrectly writes back to the GAS register 0x4154 to clear EN_IRQ + OCCURRRED, the firmware event manager write handler interprets that write as an attrs update, which zeros the EVENT_REPORT bit in the MRPC completion Async Header Register. For these events we want to skip and not write back.
BenReed161
force-pushed
the
skip-all-mrpc-comp
branch
from
1fa6d25 to
3744eae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation just skips the MRPC_COMP, it should also skip the TWI and CLI MRPC completions + ASYNC Ccompletion events too.
The kernel ISR mask_event incorrectly writes back to the GAS register 0x4154 to clear EN_IRQ + OCCURRRED, the firmware event manager write handler interprets that write as an attrs update, which zeros the EVENT_REPORT bit in the MRPC completion Async Header Register.
For these events we want to skip and not write back.