auto-triage: ensure /username/modelseed workspace folder exists before reconstruct#2
Draft
jplfaria wants to merge 2 commits into
Draft
auto-triage: ensure /username/modelseed workspace folder exists before reconstruct#2jplfaria wants to merge 2 commits into
jplfaria wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause (modelseed-api-ops#11): PATRIC workspace returns Insufficient permissions (not Not Found) when create() targets a path whose parent directory has never been initialised. First-time users have no /username/modelseed folder, so reconstruct() fails at the final save step with a misleading error.\n\nFix: added _ensure_ws_folder(ws, path) helper that calls ws.create with overwrite=1 on the folder path before the model write in both reconstruct and _run_bulk_reconstruct. Idempotent for existing folders.\n\nTests: tests/unit/test_ensure_ws_folder.py with 4 unit tests.