Refactor result package#152
Merged
Merged
Conversation
This patch removes some parts of the overall object in favor of putting everything into subcheck objects.
martialblog
reviewed
Jun 15, 2026
martialblog
left a comment
martialblog
left a comment
Member
There was a problem hiding this comment.
Very nice.
Note:
if state < check.OK || state > check.Unknown {
return errors.New("Default State is not a valid result state. Got " + state.String() + " which is not valid")
}
We can probably remove this, since we now have proper types.
Member
Author
done |
Member
Author
|
sadly this conflicts with the recent changes on |
added 4 commits
June 15, 2026 15:27
This patch removes the "Summary" attribute from the overall object and replaces the functionality with a generated summary. If the overall state is OK, the summary is either a user given string from a new "OKSummary" attribute or auto generated (as previously) with just a small statistics over the states of all PartialResults. If the overall state is NOT OK, the summary is fetched from the worst-deepest-first PartialResult Output.
martialblog
requested changes
Jun 15, 2026
martialblog
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch removes some parts of the overall object in favor of putting everything into subcheck objects.
See #151