feat(gpu): move device selection to driver config#1815
Open
elezar wants to merge 1 commit into
Open
Conversation
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
gpu-device-driver-config-elezar
branch
from
14e335a to
5b6ab51
Compare
|
🌿 Preview your docs: https://nvidia-preview-pr-1815.docs.buildwithfern.com/openshell |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move exact GPU device selection out of the public sandbox proto/API and into driver-specific
driver_configfields.Related Issue
Related to #1716 and #1812.
Changes
gpu_devicefields, reserving the field numbers and names.--gpu-deviceflag.driver_config.cdi_devices.driver_config.gpu_device_ids, currently limited to one entry.gpu=truewhen exact GPU device config is supplied, and reject exact selection for Kubernetes.--driver-config-jsonpath.Testing
mise run pre-commitpassesChecklist