Skip to content

[FIX] document_page_tag: convert create to api.model_create_multi #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
miquelrosell99 wants to merge 1 commit into
base: 17.0
Choose a base branch
from
Open

[FIX] document_page_tag: convert create to api.model_create_multi #613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions document_page_tag/models/document_page_tag.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,14 @@ class DocumentPageTag(models.Model):
("unique_name", "unique(name)", "Tags must be unique"),
]

@api.model
def create(self, vals):
@api.model_create_multi
def create(self, vals_list):
"""Be nice when trying to create duplicates"""
existing = self.search([("name", "=ilike", vals["name"])], limit=1)
if existing:
return existing
return super().create(vals)
result = self.env["document.page.tag"]
for vals in vals_list:
existing = self.search([("name", "=ilike", vals.get("name", ""))], limit=1)
if existing:
result |= existing
else:
result |= super().create(vals)
return result
Loading