Skip to content

core/validatorapi: proposer duties v2#4564

Merged
KaloyanTanev merged 1 commit into
mainfrom
kalo/proposer-duties-v2
Jun 22, 2026
Merged

core/validatorapi: proposer duties v2#4564
KaloyanTanev merged 1 commit into
mainfrom
kalo/proposer-duties-v2

Conversation

@KaloyanTanev

Copy link
Copy Markdown
Collaborator

A new endpoint introduced in gloas. However, some clients already use it...

On Charon's side nothing changes for it, so we can reuse the same function.
https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Validator/getProposerDutiesV2

category: feature
ticket: none

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support in Charon’s validator API router for the Beacon API proposer duties v2 endpoint, reusing the existing proposer duties handler since the server-side behavior is unchanged.

Changes:

  • Registered a new GET route: /eth/v2/validator/duties/proposer/{epoch}.
  • Added a raw-router test validating the v2 proposer duties response shape and metadata fields.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
core/validatorapi/router.go Registers the new proposer duties v2 route pointing to the existing proposer duties handler.
core/validatorapi/router_internal_test.go Adds a raw-router test covering the new v2 endpoint response, including dependent_root and execution_optimistic.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread core/validatorapi/router_internal_test.go
Comment thread core/validatorapi/router_internal_test.go
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.21%. Comparing base (0e652d3) to head (0e17097).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4564      +/-   ##
==========================================
+ Coverage   57.20%   57.21%   +0.01%     
==========================================
  Files         245      245              
  Lines       33442    33448       +6     
==========================================
+ Hits        19131    19138       +7     
  Misses      11885    11885              
+ Partials     2426     2425       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KaloyanTanev KaloyanTanev merged commit b7b652c into main Jun 22, 2026
11 of 12 checks passed
@KaloyanTanev KaloyanTanev deleted the kalo/proposer-duties-v2 branch June 22, 2026 16:30
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants