Skip to content

cleanup: drop internal-tooling references and finished-investigation scaffolds#98

Merged
josephnef merged 1 commit into
masterfrom
cleanup-internal-refs
Jun 11, 2026
Merged

cleanup: drop internal-tooling references and finished-investigation scaffolds#98
josephnef merged 1 commit into
masterfrom
cleanup-internal-refs

Conversation

@josephnef

Copy link
Copy Markdown
Collaborator

Summary

Post-port hygiene sweep: the codebase is open source and should be self-explanatory, but comments referenced an internal notes system, files that were never committed (TODO.md, tools/gen_rtw88_mimic.py), and carried debugging scaffolds from the now-finished 8814 TX investigation. All factual content is preserved in-place; only the pointers and dead scaffolds go. Net −4,831 lines.

Comments rewritten as self-contained

  • Internal-notes citations → plain statements (8814 RF paths C/D are write-only by HW design; 8821 ch100 wedge is triggered by the second channel-set, not the band-switch)
  • TODO.md pointers → "kernel-vs-devourer register canary diff" provenance
  • Dropped the /tmp/rtw88_init.seq / gen_rtw88_mimic.py pointer (never committed)

Scaffolds removed (superseded or never validated)

  • DEVOURER_OOT_REPLAY + hal/Hal8814_PostFwdlReplay.h — 135 KB usbmon replay table; superseded by the kernel-faithful fwdl bracket (8814: boot the 3081 MCU — TX + RX on every band #97)
  • DEVOURER_8814_DEINIT_BEFORE_INIT — experimental gate; the warm-state wedge it targeted no longer reproduces
  • DEVOURER_PROBE_MCUFWDL demo probe and the unconditional 18-line "8814A TX-state" init log dump

Docs

  • tests/README.md: stale "known broken cells (8814 RX, 8821 TX/RX)" claims replaced with the current operative caveat (kernel-TX cells with 8814: 88XXau host-push beacon injection doesn't emit — judge by devourer-TX cells)
  • docs/8814-port-audit.md deleted — investigation-process report (pending-validation plans); history lives in git

Kept deliberately: the 2024-era vendor-port TODOs (inherited-code provenance) and DEVOURER_USB_SENTINEL (self-documented, wired to the in-repo usbmon diff tooling).

Validation

  • Build green (GCC, all targets)
  • Hardware smoke after the init-path removals: RTL8814AU TX ch6 → 6,238 frames on-air at the monitor witness; submits clean

🤖 Generated with Claude Code

…scaffolds

The codebase is open source and must be self-explanatory; comments
referenced an internal notes system (kaeru), a TODO.md and a generator
script that were never committed, and carried debugging scaffolds from
the now-finished 8814 port effort. All factual content is preserved
in-place; only the pointers and dead scaffolds go:

- comments: kaeru citations rewritten as self-contained statements
  (8814 RF C/D write-only, 8821 ch100 second-channel-set wedge);
  TODO.md pointers rewritten (kernel canary-diff provenance);
  /tmp/rtw88_init.seq + tools/gen_rtw88_mimic.py pointer dropped
- DEVOURER_OOT_REPLAY + hal/Hal8814_PostFwdlReplay.h (135 KB usbmon
  replay table): superseded by the kernel-faithful fwdl bracket
- DEVOURER_8814_DEINIT_BEFORE_INIT: never-validated experimental
  scaffold; the warm-state wedge it targeted no longer reproduces
- DEVOURER_PROBE_MCUFWDL demo probe and the unconditional 18-line
  "8814A TX-state" init dump: TX-investigation diagnostics
- tests/README.md: stale "known broken cells" claims replaced with the
  current operative caveat (88XXau beacon-inject kernel-TX cells)
- docs/8814-port-audit.md: investigation-process report (pending-
  validation plans, work-package refs) — history lives in git

Smoke-tested on hardware after the init-path removals: 8814 TX ch6
6238 frames on-air at the witness.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@josephnef josephnef merged commit 960a79c into master Jun 11, 2026
5 checks passed
@josephnef josephnef deleted the cleanup-internal-refs branch June 11, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant