Handle the STRICT host name verifier explicitly (CodeQL java/missing-case-in-switch)#244
Open
vharseko wants to merge 1 commit into
Open
Conversation
…case-in-switch) AsyncHttpClientProvider switched on the HostnameVerifier option but only had a case for ALLOW_ALL, relying on a pre-initialised DefaultHostnameVerifier to cover STRICT. Give the switch a default branch that assigns the strict verifier, the same shape already used by SyncHttpClientProvider. Behaviour is unchanged - STRICT still maps to DefaultHostnameVerifier - but the switch now covers every enum value and the two client providers are consistent.
maximthomas
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the
java/missing-case-in-switchalert inAsyncHttpClientProvider(the switch had no case for
HostnameVerifier.STRICT).The switch pre-initialised the verifier and only overrode it for
ALLOW_ALL:STRICTtherefore fell through and kept the defaultDefaultHostnameVerifier(the correct behaviour), but the switch covered only one of the two enum values.
Fix
Add a
defaultbranch that assignsDefaultHostnameVerifier, matching the shapealready used by the sibling
SyncHttpClientProvider:Behaviour is unchanged (
STRICTstill maps toDefaultHostnameVerifier); theswitch now covers every value and the two providers are consistent.
Testing
mvn -o -pl commons/http-framework/client-apache-async compile— BUILD SUCCESS.