Use short-circuit && in Exchange.removeKeyRangeInternal (CodeQL java/non-short-circuit-evaluation)#245
Open
vharseko wants to merge 2 commits into
Conversation
…non-short-circuit-evaluation) The anti-value guard combined removeOnlyAntiValue with the isKeyRangeAntiValue check using the non-short-circuit & operator, so isKeyRangeAntiValue was always evaluated even when removeOnlyAntiValue was false. isKeyRangeAntiValue only reads buffer state and has no side effects, so switching to && is behaviour-preserving and skips the redundant call when the flag is already false.
vharseko
added
codeql
maximthomas
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the
java/non-short-circuit-evaluationalert inExchange.The anti-value guard used the non-short-circuit
&operator:so
isKeyRangeAntiValue(...)was evaluated even whenremoveOnlyAntiValuewasalready
false.Fix
Switch to
&&.isKeyRangeAntiValueonly reads buffer state (key-blockoffsets, right sibling, primordial-anti-value flag) and has no side effects, so
the change is behaviour-preserving — it merely skips the redundant call when
removeOnlyAntiValueisfalse.Testing
mvn -o -pl persistit/core compile— BUILD SUCCESS.