Add missing @Override annotations (CodeQL java/missing-override-annotation)#246
Open
vharseko wants to merge 2 commits into
Open
Add missing @Override annotations (CodeQL java/missing-override-annotation)#246vharseko wants to merge 2 commits into
vharseko wants to merge 2 commits into
Conversation
…ation) Annotate 308 methods that override a superclass method or implement an interface method but were missing @OverRide, across 97 files in 9 modules. Annotation-only and behavior-preserving; verified by compiling every affected Maven module (plus javac for the two persistit Ant examples).
vharseko
added
codeql
maximthomas
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeQL:
java/missing-override-annotationAdds the missing
@Overrideannotation to 308 methods across 97 files in 9 modules. Each annotated method overrides a superclass method or implements an interface method but lacked the annotation.The change is annotation-only and behavior-preserving. Because
@Overrideon a non-overriding method is a compile error, correctness is guaranteed by compilation:mvn -pl <module> compile).persistit/examplesfiles (Ant-built, not in the Maven reactor) were verified withjavacagainstpersistit-core.Distribution
Closes the open
java/missing-override-annotationcode-scanning alerts.