fix(tools): fixed profiling support for rust asap-query-engine#343
Merged
milindsrivastava1997 merged 1 commit intoMay 19, 2026
Conversation
milindsrivastava1997
deleted the
341-profilingquery_engine-config-flag-is-broken-for-rust-query-engine
branch
milindsrivastava1997
added a commit
that referenced
this pull request
Jun 25, 2026
PR #343 removed do_profiling from EngineConfig (deny_unknown_fields) but missed updating benchmarks/config/engine_config.yaml and examples/engine_config.yaml. The field causes the query engine to fail at startup, which broke the full-stack CI. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
milindsrivastava1997
added a commit
that referenced
this pull request
Jun 26, 2026
…437) * feat(planner): added millisecond precision support * feat: added millisecond-level precision support in planner and query engine * updated experiment infra and yaml config files * more python changes for milliseconds * updated quickstart, drop-in and docs * docs(query-engine,planner): clarify unit ambiguities raised in PR #437 review - StoreQueryParams/QueryTimestamps: doc start/end fields as ms since epoch - frequency.rs step_ms: inline comment that LogEntry.step is seconds (Prometheus log format), explaining the *1000 - sql.rs SQLPatternMatcher boundary and config.py dual-key transform: confirmed intentional, already documented; no change needed - SQLPatternMatcher ms migration partially tracked by #427; prometheus_client ms migration tracked by #442 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(config): remove stale do_profiling field from engine config YAMLs PR #343 removed do_profiling from EngineConfig (deny_unknown_fields) but missed updating benchmarks/config/engine_config.yaml and examples/engine_config.yaml. The field causes the query engine to fail at startup, which broke the full-stack CI. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * more fixes * addressed comments * fixed a smell * reverted arguments for quickstart and dropin, as they had version-pinned images * reverted changes to asap-quickstart and asap-dropin * fixed bug in CI due: benchmarks/docker-compose.yml overrides the image to the freshly built SHA tag but doesn't override the command, so the new binary (which uses _ms arg names) received the old arg names from asap-quickstart/docker-compose.yml * more CI fixes because cmd line args have been changed --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.