Skip to content

fix(tools): update .start() to use DiscoveryBackend instead of prometheus_url #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milindsrivastava1997 merged 1 commit into from
Jun 26, 2026
Merged

fix(tools): update .start() to use DiscoveryBackend instead of prometheus_url #453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion asap-tools/experiments/experiment_only_ingest_path.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
PrometheusHealthMonitor,
ControllerService,
)
from experiment_utils.services.misc import DiscoveryBackend

# Register custom resolver for LOCAL_EXPERIMENT_DIR before Hydra processes config
OmegaConf.register_new_resolver(
Expand Down Expand Up @@ -303,7 +304,11 @@ def main(cfg: DictConfig):
streaming_engine=args.streaming_engine,
controller_remote_output_dir=CONTROLLER_REMOTE_OUTPUT_DIR,
punting=args.controller_punting,
prometheus_url=prometheus_url,
discovery_backend=DiscoveryBackend(
type="prometheus",
url=prometheus_url,
database=None,
),
)
sync.rsync_controller_config_remote_to_local(
provider,
Expand Down
7 changes: 6 additions & 1 deletion asap-tools/experiments/experiment_run_grafana_demo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
SystemExportersService,
GrafanaService,
)
from experiment_utils.services.misc import DiscoveryBackend

COMPRESS_JSON = True
GRAFANA_ADMIN_PASSWORD = "admin"
Expand Down Expand Up @@ -356,7 +357,11 @@ def main(cfg: DictConfig):
streaming_engine=args.streaming_engine,
controller_remote_output_dir=CONTROLLER_REMOTE_OUTPUT_DIR,
punting=args.controller_punting,
prometheus_url=prometheus_url,
discovery_backend=DiscoveryBackend(
type="prometheus",
url=prometheus_url,
database=None,
),
)
sync.rsync_controller_config_remote_to_local(
provider,
Expand Down
Loading