feat(asap-tools): add remote_monitor (CPU/memory) support to experiment_run_clickhouse.py#480
Merged
milindsrivastava1997 merged 7 commits intoJul 1, 2026
Conversation
Closed
4 tasks
milindsrivastava1997
requested changes
Jun 30, 2026
…riments - remote_monitor.py: make --backend_type required (drop default). - remote_monitor_service.py: make backend_type required; consolidate process keyword selection in one place (clickhouse vs prometheus), dropping the monitor_keywords argument; revert remote_monitor invocation to python3. - experiment_run_clickhouse.py: remove flow.remote_monitor flag (monitoring is always on); drop now-dead _run_query_client and _clickhouse_monitor_keywords. - config.yaml: remove flow.remote_monitor flag. - experiment_run_e2e.py: pass backend_type=prometheus explicitly. Co-authored-by: Cursor <cursoragent@cursor.com>
80994ee to
a67d2be
Compare
Contributor
|
Follow-up cleanup on the variable names introduced here:
The two params are related (both about the backend stack) but not the same axis — the shared |
milindsrivastava1997
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
experiment_run_clickhouse.pyflow.remote_monitorflag gates monitoring._run_query_workload()wraps the prometheus-client invocation inRemoteMonitorServicewhen enabled; otherwise unchanged_run_query_client()._clickhouse_monitor_keywords()selects ps-matchable process keywords:clickhouse(baseline) andquery_engine_rust(sketchdb).config/config.yamlflow.remote_monitor: false(default off).RemoteMonitorService.start()backend_typeandmonitor_keywordsparameters.monitor_keywordsis provided, use it directly (skip Prometheus-config keyword discovery).python3.11(deps live there on the node) instead ofpython3.--backend_typethrough toremote_monitor.py.arroyo_servicemade optional.remote_monitor.py--backend_typearg, forwarded toPrometheusClientService(was hardcoded"prometheus");clickhouseskips PromQL query-time alignment.Issues fixed along the way
python3on the node lackedloguru/experiment deps → switched topython3.11.clickhouse-servercontainer name didn't matchps(host-network bare-metal ClickHouse) → useclickhousekeyword.start()→ reordered.Usage
Then:
Output