fix(tools): pin TZ=UTC across for ClickHouse experiments#514
Draft
milindsrivastava1997 wants to merge 1 commit into
Draft
fix(tools): pin TZ=UTC across for ClickHouse experiments#514milindsrivastava1997 wants to merge 1 commit into
milindsrivastava1997 wants to merge 1 commit into
Conversation
Naive datetime-string time literals in SQL queries were parsing inconsistently between ClickHouse (defaults to UTC) and asap-planner / query_engine_rust (local shell TZ), silently disagreeing by the shell's UTC offset. Also passes optional sketch_parameters through to the generated SQL planner input, and rsyncs init_sql_file to the remote node instead of assuming it's already there.
milindsrivastava1997
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TZ=UTCin the ClickHouse, asap-planner, and query-engine docker-compose configs and remote-launch commands so naive datetime-string time literals in SQL queries parse identically everywhere (previously could silently disagree by the shell's local UTC offset vs. ClickHouse's UTC default).sketch_parametersthrough from experiment config into the generated SQL planner input YAML.init_sql_fileto the remote node before executing it, instead of assuming it's already present there.