Add 2028 NYSE holidays and early closes to Equity-usa market hours#9597
Open
DogInfantry wants to merge 1 commit into
Open
Add 2028 NYSE holidays and early closes to Equity-usa market hours#9597DogInfantry wants to merge 1 commit into
DogInfantry wants to merge 1 commit into
Conversation
Extends the Equity-usa-[*] entry in the market hours database through 2028. Previously holidays ended at 12/24/2027 and early closes at 12/24/2026. Holidays (full closes): 1/17 (MLK), 2/21 (Presidents), 4/14 (Good Friday), 5/29 (Memorial), 6/19 (Juneteenth), 7/4 (Independence), 9/4 (Labor), 11/23 (Thanksgiving), 12/25 (Christmas). No New Year entry: 1/1/2028 is a Saturday. Early closes (1:00 PM ET): 7/3/2028 (day before Independence Day) and 11/24/2028 (day after Thanksgiving). No Christmas Eve early close: 12/24/2028 is a Sunday. Fixes QuantConnect#9406 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds 2028 NYSE holidays and early closes to the
Equity-usa-[*]entry ofData/market-hours/market-hours-database.json, per #9406. Previously the entry's holidays ended at12/24/2027and early closes at12/24/2026.Dates added
Holidays (full closes):
1/17/2028– Martin Luther King Jr. Day2/21/2028– Washington's Birthday4/14/2028– Good Friday5/29/2028– Memorial Day6/19/2028– Juneteenth7/4/2028– Independence Day9/4/2028– Labor Day11/23/2028– Thanksgiving12/25/2028– ChristmasNo New Year's Day entry:
1/1/2028is a Saturday (NYSE does not observe it on the preceding Friday).Early closes (1:00 PM ET):
7/3/2028– day before Independence Day (Monday)11/24/2028– day after Thanksgiving (Friday)No Christmas Eve early close:
12/24/2028is a Sunday.All weekdays were verified against the NYSE 2028 holiday calendar.
Note on scope
A few other US entries share the identical NYSE holiday list (e.g. the US Option/IndexOption markets) and still end at 2027. This PR limits changes to
Equity-usa-[*]as the issue specifies. Glad to extend the same 2028 dates to the sibling entries in this PR if that is preferred.Fixes #9406