[kalman] update RV notation#900
Conversation
Update the two "Constant value of state x_t" comments to X_t so the code comments match the uppercase random-variable convention used in the surrounding prose. The realized initial value x_0 comment stays lowercase by design. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Reviewed — the uppercase/lowercase RV convention is applied correctly and consistently, and the new I pushed a small follow-up commit (dc7ca23) updating the two |
📖 Netlify Preview Ready!Preview URL: https://pr-900--sunny-cactus-210e3e.netlify.app Commit: 📚 Changed LecturesBuild Info
|
There was a problem hiding this comment.
Pull request overview
This PR updates the Kalman filter lecture (lectures/kalman.md) to consistently apply the “uppercase = random variable / lowercase = realization” convention across the Implementation section and Exercises, aligning with the notation introduced earlier in the lecture and requested in #898.
Changes:
- Updated the
LinearStateSpacemodel equations in the Implementation section to use$X_t$ /$Y_t$ for random state and signal variables. - Revised Exercises 1–4 text and code comments to use
$X_t$ for random states while keeping lowercase for realizations/estimates/code variables. - Clarified in Exercise 3 that the plotted squared errors are based on simulated realizations (and added an explicit note tying
x[:, t]to the realized$X_t$ ).
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
Many thanks @mmcky for the update and I've addressed the comments from Copilot as well. Best, |
# Conflicts: # lectures/kalman.md
|
Hi @longye-tian — I've resolved the merge conflict on this branch (merged latest The conflict arose because #908 ("[kalman] Fix errors, modernize code, and unify notation") landed on I resolved each by keeping your changes and adopting
The one point worth your eye: #908 set the state shock to uppercase Could you confirm the resolution reads the way you intended? Thanks! |
|
@longye-tian My bad, I missed this PR and then made some related edits. Sorry about that. Could you please provide a brief review of the current status of the lecture and this PR? |
Many thanks @mmcky They all looks good to me! |
No worries @jstac. I think @mmcky has resolved all the merge conflicts with your PR #908 . This PR and yours now share the same notations and this PR complements yours by focuses on the Implementation section and Exercises section. Best, |
Hi @mmcky
This PR updates the RV notation following #898 .
In particular, this extends the new uppercase/lowercase convention to the Implementation section and Exercises:
Best,
Longye