Document non-seekable file handle limitations#10
Open
asubbarao wants to merge 1 commit into
Open
Conversation
ShellFileSystem does not override Seek/SeekPosition (they throw via the base class), GetFileSize always returns 0, and Reset throws. Add a comment block near CanSeek() so extension authors who consume shellfs file handles know to check CanSeek() or guard these calls. Related: Query-farm#9 (read_text/read_blob failures with pipe processes)
Open
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a comment block to
shell_file_system.hppdocumenting that:Seek/SeekPositionare not overridden and throw via the base classGetFileSizealways returns 0ResetthrowsCanSeek()or guard these callsRelated to #9 — the
read_text/read_blobpipe failures are likely the same root cause (those functions also callSeekPositionunconditionally on the returned handle).Fix developed with Claude Opus 4 and Grok (xAI) for the initial implementation pass.