fix: constrained move mode improvements#10026
Open
mikeharv wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #10023 #10024 #10025
Proposed Changes
This updates
determineConnectionOffset()andupdateConnectionPreview()in order to resolve three separate bugs.local.getOffsetInBlock()instead oflocal.x/local.y.connectionCandidatebefore calculating block position on workspace.Reason for Changes
RenderedConnection.xandRenderedConenction.yvalues have not been set and are equal to the coordinates of the block itself. This causes the block to be positioned incorrectly. See Block moved to bad position when inserting from toolbox #100232-3. Blocks were being moved onto the workspace further down than was necessary because the size of the content was influenced by the prior block position. By first hiding the preview and filtering out the dragging block from the content, we can get accurate bounds. See #10025
This also adds a slight indent to the position of statements as the

nextConnectionof a block is slightly offset: