Fixed as Per Request in prior PR https://github.com/RsyncProject/rsync/pull/1013#1014
Open
ThatByteGuy wants to merge 2 commits into
Open
Fixed as Per Request in prior PR https://github.com/RsyncProject/rsync/pull/1013#1014ThatByteGuy wants to merge 2 commits into
ThatByteGuy wants to merge 2 commits into
Conversation
Use the remaining byte count for retry writes and avoid using a size_t sentinel for write failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update:
During review it was pointed out that the Solaris write loop also uses
bufpos = -1as an error sentinel even thoughbufposis asize_t.This wraps to
SIZE_MAX, allowing the final return expression toreport success after a failed write.
The updated patch returns
-1directly on non-retryable write errorsinstead of using a sentinel value.