2026-07-07 review: safety-loop findings, test portability, preview panel#4
Open
jacobson30-bot wants to merge 1 commit into
Open
2026-07-07 review: safety-loop findings, test portability, preview panel#4jacobson30-bot wants to merge 1 commit into
jacobson30-bot wants to merge 1 commit into
Conversation
…w panel Read-only review at b27a4c2 (full suite run in mock mode, 292 passing). Headline findings: - HIGH: Pause suspends safety polling while the scan keeps running (_wait_if_paused sleeps without _check_safety; Pause is reachable mid-scan from Sweep/Mosaic). - MED: tunneling-loss detection cannot fire on the fallback current path (frame max includes historical rows); tunnel-lost halts end in RunnerState.FINISHED; tests hard-require a sibling ProbeFlow checkout (10 failures on any other layout). - Plus two LOW items and a structural note on preview_panel.py (4,157 lines, bypasses the detector contract). Strengths called out explicitly: fail-closed safety monitor, closed-loop XY motion, runner lifecycle hygiene, import-boundary tests. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read-only review of
mainatb27a4c2— the deliverable is one document, docs/reviews/2026-07-07-review.md. No functional code was touched. The full suite was run on macOS in mock mode (292 passing once the sibling-checkout fixture assumption was satisfied — that assumption is itself finding 4).Findings, severity-ordered:
_wait_if_pausedsleeps without_check_safety; Pause is reachable mid-scan from the Sweep/Mosaic panels). Worth fixing before the next overnight campaign.RunnerState.FINISHED, contradicting the emitted error.tests/test_preview_panel.pyhard-requires a ProbeFlow git checkout next to ScanFlow (10 failures on any other layout, no skip guard).int(getp(...)) or 9turns a legitimate preamp exponent 0 into 9; a never-started scan is treated as a completed step.preview_panel.py(4,157 lines) bypasses the §13 detector contract with six direct probeflow imports; theProbeFlowFeatureDetectorslot is still empty.The doc also calls out what's genuinely strong (fail-closed safety monitor, closed-loop XY motion, runner lifecycle hygiene, the import-boundary tests) so the findings land with context.
Follow-up on the ProbeFlow side (not in this PR): a pinning test for the six probeflow surfaces ScanFlow imports, so ProbeFlow refactors break our CI instead of ScanFlow.
🤖 Generated with Claude Code