Skip to content

refactor(word): use DB-backed single-flight completion#334

Merged
SolfE merged 8 commits into
developfrom
word-singleflight-db-completion
Jun 16, 2026
Merged

refactor(word): use DB-backed single-flight completion#334
SolfE merged 8 commits into
developfrom
word-singleflight-db-completion

Conversation

@SolfE

@SolfE SolfE commented Jun 15, 2026

Copy link
Copy Markdown
Member

Summary

  • 단어 single-flight key 구성을 word + targetLanguage + resultSchemaVersion 중심으로 단순화했습니다.
  • Redis result cache를 제거하고, leader가 DB 저장까지 완료한 뒤 done Pub/Sub으로 follower를 깨우도록 변경했습니다.
  • follower는 Redis에 저장된 응답 대신 DB 조회 supplier로 결과를 확인하도록 정리했습니다.
  • done publish 실패 시에도 lock이 해제되도록 보강하고, leader의 WORD_IS_MEANINGLESS 예외가 invalid-word cache에 반영되도록 수정했습니다.

@SolfE SolfE force-pushed the word-singleflight-db-completion branch from a6bb8af to 40a92cc Compare June 15, 2026 14:51
@SolfE SolfE marked this pull request as ready for review June 15, 2026 14:53

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 40a92cc6fb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/main/java/com/linglevel/api/word/service/WordService.java Outdated
@SolfE

SolfE commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

@codex

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9e7e317fb5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SolfE

SolfE commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

@codex

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 4ec3824d8e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SolfE SolfE merged commit 7384b4d into develop Jun 16, 2026
1 check passed
@SolfE SolfE deleted the word-singleflight-db-completion branch June 16, 2026 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant