Run E2E app cleanup before sharded tests#7777
Draft
alfonso-noriega wants to merge 1 commit into
Draft
Conversation
github-actions
Bot
added
the
no-changelog
alfonso-noriega
force-pushed
the
06-10-run_e2e_app_cleanup_before_sharded_tests
branch
from
059e901 to
c52a546
Compare
alfonso-noriega
force-pushed
the
06-10-run_e2e_app_cleanup_before_sharded_tests
branch
from
c52a546 to
2ce70e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
PR #7764 is blocked on E2E failures caused by the shared E2E organization hitting its app quota:
The E2E suite already has a cleanup utility for stale
E2E-apps, but PR CI only ran it manually/out-of-band. When the org is already at quota, every sharded E2E job that needscreate-appfails before the actual test assertions can run.WHAT is this pull request doing?
Adds a separate PR workflow preflight job,
E2E preflight app cleanup, that runs before the sharded E2E tests and deletes stale E2E apps with zero installs:pnpm exec tsx scripts/cleanup-apps.ts --deleteThe sharded E2E jobs now depend on that cleanup job, so they start after the shared org has had a chance to free app quota.
This intentionally uses
--deleteonly: it avoids store/app uninstall side effects in CI and only removes apps that the dashboard reports as having no installs.How to test your changes?
Validated locally:
Full E2E requires Shopify E2E secrets and is validated by CI.
Post-release steps
None.
Checklist