Skip to content

Delete deprecated get_azure_share_sas action#79

Merged
f-thiele merged 3 commits into
mainfrom
copilot/delete-deprecated-get-azure-share-sas
Apr 21, 2026
Merged

Delete deprecated get_azure_share_sas action#79
f-thiele merged 3 commits into
mainfrom
copilot/delete-deprecated-get-azure-share-sas

Conversation

Copilot AI commented Apr 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Delete deploy_poetry_project_to_azfs/ directory
  • Delete deploy_dbt_project_to_azfs/ directory
  • Delete deploy_data_schemas_to_azfs/ directory
  • Delete run_azcopy/ directory
  • Remove the 4 entries from README TOC and renumber remaining items
  • Remove the 4 documentation sections from README
  • Fix stale cross-reference in generate_version section

Copilot AI linked an issue Apr 20, 2026 that may be closed by this pull request
Delete deprecated get_azure_share_sas #54
Closed
Copilot AI changed the title [WIP] Remove deprecated get_azure_share_sas action Delete deprecated get_azure_share_sas action Apr 20, 2026
Copilot AI requested a review from f-thiele April 20, 2026 10:13
@f-thiele

f-thiele commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

@george-zubrienko seems like the action has been used in a couple of places - should we delete those too? I.e.

  1. deploy_poetry_project_to_azfs (destination)
  2. deploy_dbt_project_to_azfs (destination)
  3. deploy_data_schemas_to_azfs (destination)
  4. run_azcopy (target)

my take would be yes but want to make sure that was intended by the GH issue

@george-zubrienko

george-zubrienko commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

@george-zubrienko seems like the action has been used in a couple of places - should we delete those too? I.e.

  1. deploy_poetry_project_to_azfs (destination)

  2. deploy_dbt_project_to_azfs (destination)

  3. deploy_data_schemas_to_azfs (destination)

  4. run_azcopy (target)

my take would be yes but want to make sure that was intended by the GH issue

Yes, 🚮 it.

@f-thiele
Delete deploy_poetry_project_to_azfs, deploy_dbt_project_to_azfs, dep…
a623580 
…loy_data_schemas_to_azfs, run_azcopy actions and update README

Agent-Logs-Url: https://github.com/SneaksAndData/github-actions/sessions/b64c8cf1-5f0f-4f9c-80ce-ce197745dff8

Co-authored-by: f-thiele <16508158+f-thiele@users.noreply.github.com>
@f-thiele f-thiele marked this pull request as ready for review April 21, 2026 07:29
@f-thiele f-thiele requested a review from a team as a code owner April 21, 2026 07:29
@f-thiele

f-thiele commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

I identified seven repos in our org that currently use one of the deleted actions - they are all stale so I will archive them after approval but before merging this.

george-zubrienko
george-zubrienko approved these changes Apr 21, 2026
View reviewed changes

@george-zubrienko george-zubrienko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, bots for the win!

@f-thiele f-thiele merged commit f88c9b5 into main Apr 21, 2026
1 check passed
@f-thiele f-thiele deleted the copilot/delete-deprecated-get-azure-share-sas branch April 21, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@george-zubrienko george-zubrienko george-zubrienko approved these changes
+1 more reviewer
@f-thiele f-thiele f-thiele approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@f-thiele f-thiele

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Delete deprecated get_azure_share_sas

3 participants

@f-thiele @george-zubrienko