Skip to content

Provide GoDoc generation#104

Merged
Vladyslav-Kuksiuk merged 3 commits into
masterfrom
add-godoc
Jul 8, 2026
Merged

Provide GoDoc generation#104
Vladyslav-Kuksiuk merged 3 commits into
masterfrom
add-godoc

Conversation

@Vladyslav-Kuksiuk

Copy link
Copy Markdown
Collaborator

This PR provide GoDoc API generation configuration.

Resolves this issue.

@Vladyslav-Kuksiuk Vladyslav-Kuksiuk self-assigned this Jul 7, 2026
@Vladyslav-Kuksiuk Vladyslav-Kuksiuk marked this pull request as ready for review July 7, 2026 17:20
@Oleg-Melnik

Copy link
Copy Markdown
Collaborator

Claude Review

Note — GODOC_GOCACHE uses a fixed, shared /tmp path

scripts/godoc and scripts/godoc-serve both default:

: "${GODOC_GOCACHE:=/tmp/embed-code-go-godoc-cache}"

This is a predictable path shared across all users of the machine. On a multi-user host, if the cache directory already exists and is owned by another user, go/godoc will fail with a permission error. It's also a mildly unsafe predictable temp location.

Prefer a per-user or randomized path, e.g.:

: "${GODOC_GOCACHE:=${TMPDIR:-/tmp}/embed-code-go-godoc-cache-$USER}"

or mktemp -d. Not blocking — just a robustness improvement.

@Oleg-Melnik Oleg-Melnik left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vladyslav-Kuksiuk LGTM with a comment to address.

@Vladyslav-Kuksiuk Vladyslav-Kuksiuk merged commit 7f9d8f2 into master Jul 8, 2026
3 checks passed
@Vladyslav-Kuksiuk Vladyslav-Kuksiuk deleted the add-godoc branch July 8, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configure godoc generation

2 participants