Skip to content

Refactor comment filtering#98

Merged
Vladyslav-Kuksiuk merged 8 commits into
masterfrom
clean-up
Jul 7, 2026
Merged

Refactor comment filtering#98
Vladyslav-Kuksiuk merged 8 commits into
masterfrom
clean-up

Conversation

@Vladyslav-Kuksiuk

Copy link
Copy Markdown
Collaborator

This PR extracts common functions used across all comment-filtering mechanisms to reduce code duplication.

@Vladyslav-Kuksiuk Vladyslav-Kuksiuk self-assigned this Jul 6, 2026
@Vladyslav-Kuksiuk Vladyslav-Kuksiuk marked this pull request as ready for review July 6, 2026 16:42
@Oleg-Melnik

Oleg-Melnik commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Claude Review

Optional cleanup (non-blocking): csharpInterpolation.start = "{" in csharp_filter.go is set but never read — C#'s interpolated-string-text path checks a literal '{' and only openBrace/closeBrace are consumed by consumeInterpolationCodeByte. It's harmless (it documents the struct consistently with the JS/Kotlin interpolation forms, where start is used), so no change is required — just flagging it as dead within the C# path.

@Oleg-Melnik Oleg-Melnik left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vladyslav-Kuksiuk LGTM with a minor comment.

Base automatically changed from improve-vb-filtering to master July 7, 2026 09:16
Comment thread embedding/commentfilter/csharp_filter.go
Comment thread embedding/commentfilter/javascript_filter.go
@Vladyslav-Kuksiuk Vladyslav-Kuksiuk merged commit 1347072 into master Jul 7, 2026
3 checks passed
@Vladyslav-Kuksiuk Vladyslav-Kuksiuk deleted the clean-up branch July 7, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants