Fix #555: Method Pattern.draw attempts to compute Pauli flow from pattern.#561
Fix #555: Method Pattern.draw attempts to compute Pauli flow from pattern.#561matulni wants to merge 4 commits into
Pattern.draw attempts to compute Pauli flow from pattern.#561Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #561 +/- ##
==========================================
+ Coverage 90.58% 90.61% +0.02%
==========================================
Files 49 49
Lines 7481 7477 -4
==========================================
- Hits 6777 6775 -2
+ Misses 704 702 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| og = self.extract_opengraph() | ||
| gv = GraphVisualizer.from_opengraph(og=og, **options) | ||
| else: | ||
| xz_corrections = self.extract_xzcorrections() |
There was a problem hiding this comment.
Nit-picking: could we use xzcorrections for the variable name as well, following the convention of #557.
| case DrawPatternAnnotations.XZCorrections: | ||
| xzcorrections = self.extract_xzcorrections() | ||
| gv = GraphVisualizer.from_xzcorrections(xz_corr=xzcorrections, **options) | ||
| gv = GraphVisualizer.from_xzcorrections(xz_corr=xz_corrections, **options) |
There was a problem hiding this comment.
Nit‑picking: I think it's preferable to pass xz_corr as a positional argument, since there is no ambiguity here and the name isn't necessarily stable.
There was a problem hiding this comment.
These images are identical: they do not need to be updated.
There was a problem hiding this comment.
They were all generated with pytest --mpl-generate-path=tests/baseline, is it possible to selectively generate a few of them only ?
I tried to amend the commit to remove the unnecessary updates, but now I'm not sure if I just removed them altogether.
There was a problem hiding this comment.
You've removed them indeed in 923119 but you've restored them since, thanks!
We can generate only the images related to a given test by running pytest --mpl-generate-path=tests/baseline -k test-name.
matulni
force-pushed
the
fix555-vis-pauliflow
branch
from
3675e75 to
062d91e
Compare
2 participants
Fix #555: Method
Pattern.drawattempts to compute Pauli flow from pattern before fall back to flow extraction from open graph.