Updates continued#25
Merged
Merged
Conversation
Add B2 progress plumbing so live remaining-time estimates can use real completion fractions when available. `_LogCapture` now stores a clamped progress fraction, `log_utils.emit_progress()` duck-types to streams that support it, and the elapsed chip prefers a self-correcting fraction-based ETA before falling back to the prior static estimate. Wire fraction reporting into PES scans (exact point completion) and geometry optimization (fmax convergence trend), and disable optimizer fraction reporting for reorganization-energy sub-optimizations to avoid oscillating ETA resets. Extend app tests to cover fraction emission/clamping, no-op behavior on plain streams, and ETA selection/fallback behavior.
This adds B3 geometry-optimization progress improvements by recording `n_steps` in performance logs and introducing `calc_log.estimate_opt_steps()` to derive a median historical step prior from converged runs. `QuantUIApp` now passes that estimate into `optimize_geometry()`, and optimizer status/progress uses it to show `step k/~N` and floor early progress when fmax-based fractions are noisy. Tests were added for `n_steps` persistence and `estimate_opt_steps()` behavior (median, empty history, and filtering of unconverged/other calc types).
Removes roadmap/issue shorthand (e.g., M-*, EST.*, UXP.*, BUG.*) from comments and docstrings across the QuantUI modules, replacing them with neutral, date/context-based wording. This is a documentation-only readability pass to reduce internal jargon and keep implementation notes understandable without roadmap cross-references; runtime behavior is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on removing internal project code references and milestone annotations from user-facing comments, docstrings, and inline documentation throughout
quantui/app.pyandquantui/analytics.py. It also introduces a new mechanism for tracking calculation progress fractions, which will enable more accurate time-remaining estimates in the UI. The most important changes are summarized below.User-facing documentation cleanup:
M-GPU,M-EST,UXP.2, etc.) and internal references from comments, docstrings, and inline documentation inquantui/app.pyandquantui/analytics.pyto improve readability and maintainability.Progress tracking improvements:
_fractionfield to the_LogCaptureclass and a newset_progress_fractionmethod, allowing calculation modules to report completion fractions (0..1). The elapsed time ticker can now use this for more accurate, self-correcting time-remaining estimates. [1] [2]_active_logso it can access the reported progress fraction during a calculation.No functional changes were made to calculation logic or UI components; the changes are primarily to improve code clarity and introduce a foundation for enhanced progress reporting.