feat(screenshot): Add threaded JPEG/PNG screenshots without game stalls#1785
Open
bobtista wants to merge 37 commits into
Open
feat(screenshot): Add threaded JPEG/PNG screenshots without game stalls#1785bobtista wants to merge 37 commits into
bobtista wants to merge 37 commits into
Conversation
bobtista
force-pushed
the
bobtista/compressed-screenshot-f11
branch
4 times, most recently
from
20a3df1 to
37bd840
Compare
|
Some initial thoughts:
|
|
Agree with Stubbjax. JPG 90 is big file. Better make it default 80. Replace BMP screenshot with PNG screenshot. PNG is lossless compressed and always better than BMP. Make F12 take JPG 80 screenshot. Make CTRL+F12 take PNG screenshot. Make JPG Quality adjustable. Remove the old BMP code(s) and only use the new code for screenshot. |
|
Regarding Github formatting: When you write
Then it will not close this report when this is merged. Please read up on it here: |
xezon
added
Enhancement
Author
RE moving logic to core, I moved what I could to core - but there are a lot more files that need to be moved to core before this can be moved there eg WWVegas/WW3D2/* |
bobtista
force-pushed
the
bobtista/compressed-screenshot-f11
branch
3 times, most recently
from
3535e1e to
efc773f
Compare
Skyaero42
requested changes
Nov 3, 2025
bobtista
force-pushed
the
bobtista/compressed-screenshot-f11
branch
2 times, most recently
from
977a6dc to
f8162f3
Compare
OmniBlade
reviewed
Nov 5, 2025
bobtista
force-pushed
the
bobtista/compressed-screenshot-f11
branch
from
d7e8a8d to
d197bdd
Compare
34 tasks
bobtista
force-pushed
the
bobtista/compressed-screenshot-f11
branch
from
d197bdd to
9669966
Compare
|
Needs rebase. |
bobtista
force-pushed
the
bobtista/compressed-screenshot-f11
branch
from
9669966 to
4897b0b
Compare
Author
Done |
Skyaero42
requested changes
Nov 22, 2025
bobtista
force-pushed
the
bobtista/compressed-screenshot-f11
branch
from
9c99306 to
de35e57
Compare
… MessageStream members
xezon
reviewed
Jul 9, 2026
…a and MessageStream members
xezon
reviewed
Jul 9, 2026
xezon
reviewed
Jul 9, 2026
xezon
reviewed
Jul 9, 2026
xezon
reviewed
Jul 9, 2026
xezon
reviewed
Jul 9, 2026
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
xezon
reviewed
Jul 10, 2026
|
There are still comments left. |
…d handle the row pitch on the screenshot thread
xezon
reviewed
Jul 14, 2026
xezon
left a comment
xezon
left a comment
There was a problem hiding this comment.
Quite a bit of effort to unslopify the AI generation 🥲
|
|
||
| Int OptionPreferences::getJPEGQuality() const | ||
| { | ||
| OptionPreferences::const_iterator it = find("JPEGQuality"); |
There was a problem hiding this comment.
I can't find it written in Options Menu.
There was a problem hiding this comment.
Essentially I think it needs writing in Options Menu like our other new options. Otherwise the user has no default value written.
…fault constant, and simplify pitch handling
xezon
reviewed
Jul 14, 2026
xezon
left a comment
xezon
left a comment
There was a problem hiding this comment.
Looking solid. The bot has a complaint.
| virtual void preloadTextureAssets( AsciiString texture ) = 0; ///< preload texture asset | ||
|
|
||
| virtual void takeScreenShot() = 0; ///< saves screenshot to a file | ||
| virtual void takeScreenShot(ScreenshotFormat format, Int jpegQuality = 80) = 0; ///< saves screenshot in specified format |
There was a problem hiding this comment.
Maybe also use DEFAULT_JPEG_QUALITY here
|
|
||
| Int OptionPreferences::getJPEGQuality() const | ||
| { | ||
| OptionPreferences::const_iterator it = find("JPEGQuality"); |
There was a problem hiding this comment.
Essentially I think it needs writing in Options Menu like our other new options. Otherwise the user has no default value written.
|
|
||
| surfaceCopy->Unlock(); | ||
| surfaceCopy->Release_Ref(); | ||
| surfaceCopy = nullptr; |
There was a problem hiding this comment.
Minor: Maybe move this block below strlcpy(threadData->leafname ... so that all writes to threadData sit tightly together.
…ons save, and reuse the default quality constant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the old BMP screenshot with compressed JPEG screenshots that don't stall the game, and adds PNG support.
Closes #1555
Closes #106 ... sort of
Adds a new screenshot function using the stb_image_write library with background threading:
Notes
Testing