build(string): Decouple AsciiString / UnicodeString debug pointer from RTS_DEBUG#2870
Closed
Caball009 wants to merge 1 commit into
Closed
build(string): Decouple AsciiString / UnicodeString debug pointer from RTS_DEBUG#2870Caball009 wants to merge 1 commit into
Caball009 wants to merge 1 commit into
Conversation
|
| Filename | Overview |
|---|---|
| Core/GameEngine/Include/Common/AsciiString.h | Enables the private debugger pointer for _DEBUG builds. |
| Core/GameEngine/Include/Common/UnicodeString.h | Enables the private debugger pointer for _DEBUG builds. |
| Core/GameEngine/Source/Common/System/AsciiString.cpp | Initializes the ASCII debugger pointer with the matching guard. |
| Core/GameEngine/Source/Common/System/UnicodeString.cpp | Initializes the Unicode debugger pointer with the matching guard. |
Reviews (1): Last reviewed commit: "build(string): Decouple AsciiString/Unic..." | Re-trigger Greptile
|
Is this for VC6 or modern Visual Studio? Modern Visual Studio should be covered by the natvis. |
Author
|
Visual Studio.
How so? |
Author
|
It stopped working for me at some point. I just reset the CMake cache and rebuild the entire solution and it's working again :) I'm closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR makes it possible to inspect strings
AsciiStringandUnicodeStringin debug builds withoutRTS_DEBUGenabled.RTS_DEBUGmakes game starts noticeably slower so I don't always use it. It's still nice to be able to see the contents of strings in the Visual Studio debugger without any additional effort, though.