Remove instances where model_args and model_kwargs are provided #798#1424
Remove instances where model_args and model_kwargs are provided #798#1424dylanberens wants to merge 3 commits into
Conversation
…() functions; replace all run_with_cache() calls' positional args w/ keyword args
|
Hi @dylanberens! A couple notes on this one:
Additionally, the intention is to deprecate the HookedTransformers system in 4.x. Until I get around to prepping for that release and auditing to determine which features are covered under TransformerBridge, I won't know for 100% certain what will be dropped and what will be kept. Some of your work may end up deprecated before a release happens, so if you want to wait to do this work until I have a chance to do a feature audit, that is completely acceptable. |
hi @jlarson4! i've updated the title and rebased the PR to dev-4.x. I'll put this on pause until your feature audit makes it clearer what we need to adjust. thanks! |
Description
Removed *model_args from 'run_with_cache()' and 'run_with_hooks()' functions, and replaced all those function calls' positional arguments with keyword arguments-- as input= (and inputs= for all audio model calls)
Fixes #798
Type of change
Please delete options that are not relevant.
Screenshots
N/A
Checklist: