Skip to content

Special node quickfixes #2851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
YousefED wants to merge 1 commit into
base: special-node
Choose a base branch
from
+7 −4
Draft

Special node quickfixes #2851

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions packages/core/src/api/getBlockInfoFromPos.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ export function getBlockInfoWithManualOffset(
let foundBlockContent = false;

bnBlockNode.forEach((node, offset) => {
if (node.type.spec.group === "blockContent") {
if (node.type.isInGroup("blockContent")) {
// console.log(beforePos, offset);
const blockContentNode = node;
const blockContentBeforePos = bnBlockBeforePos + offset + 1;
Expand All @@ -170,7 +170,7 @@ export function getBlockInfoWithManualOffset(
afterPos: blockContentAfterPos,
};
foundBlockContent = true;
} else if (node.type.name === "blockGroup") {
} else if (node.type.isInGroup("blockGroupChild")) {
const blockGroupNode = node;
const blockGroupBeforePos = bnBlockBeforePos + offset + 1;
const blockGroupAfterPos = blockGroupBeforePos + node.nodeSize;
Expand All @@ -180,7 +180,7 @@ export function getBlockInfoWithManualOffset(
beforePos: blockGroupBeforePos,
afterPos: blockGroupAfterPos,
};
} else if (node.type.spec.group === "suggestionBlockContent") {
} else if (node.type.isInGroup("suggestionBlockContent")) {
const suggestionNode = node;
const suggestionBeforePos = bnBlockBeforePos + offset + 1;
const suggestionAfterPos = suggestionBeforePos + node.nodeSize;
Expand All @@ -199,6 +199,9 @@ export function getBlockInfoWithManualOffset(
}
});

if (!blockContent) {
blockContent = suggestionBefore || suggestionAfter;
}
if (!blockContent) {
throw new Error(
`blockContainer node does not contain a blockContent node in its children: ${bnBlockNode}`,
Expand All @@ -210,7 +213,7 @@ export function getBlockInfoWithManualOffset(
bnBlock,
blockContent,
childContainer: blockGroup,
blockNoteType: blockContent.node.type.name,
blockNoteType: blockContent.node.type.name.replace("--attributed", ""),
suggestionBefore,
suggestionAfter,
};
Expand Down
Loading