Add base account connector#2525
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 068422a. Configure here.
lwin-kyaw
reviewed
Jul 1, 2026
lwin-kyaw
previously approved these changes
Jul 2, 2026
chaitanyapotti
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds base account connector for v11 on top of the changes done here for v10: #2340
Tested with the vue-app-new
Note
Medium Risk
New wallet connection path and provider selection logic (including AA bypass) affect authentication and transaction signing for EVM users; scope is limited to an optional connector and demo wiring.
Overview
Adds a Base Account EVM external connector (v11) using
@base-org/account, mirroring the existing Coinbase connector pattern: init viacreateBaseAccountSDK, connect witheth_requestAccounts, and chain switch/add handling.SDK surface:
@web3auth/no-modalexposesbaseAccountConnectorand types;@web3auth/modalre-exports it from a new./connectorsentry (alongside coinbase).@base-org/accountis an optional peer on modal and no-modal.Wallet / AA behavior: Registers
WALLET_CONNECTORS.BASE_ACCOUNT(base-account) with login param typing. Account-abstraction wrapping is skipped when the active connector is Base Account, since it is already a smart-account style provider.Demo:
vue-app-newcan select base-account-connector, imports connectors from@web3auth/modal/connectors, fixes the connector loop off-by-one, and runs the connectors watcher withimmediate: true. Vite pre-bundles@base-org/accountand@coinbase/wallet-sdk.Also bumps workspace packages to 11.2.0 and React overrides to 19.2.7, with lockfile updates for the new dependency tree.
Reviewed by Cursor Bugbot for commit 72ec1c4. Bugbot is set up for automated code reviews on this repo. Configure here.