Skip to content

Add base account connector#2525

Merged
chaitanyapotti merged 4 commits into
masterfrom
base-account-connector
Jul 2, 2026
Merged

Add base account connector#2525
chaitanyapotti merged 4 commits into
masterfrom
base-account-connector

Conversation

@yashovardhan

@yashovardhan yashovardhan commented Jul 1, 2026

Copy link
Copy Markdown
Member

Adds base account connector for v11 on top of the changes done here for v10: #2340

Tested with the vue-app-new


Note

Medium Risk
New wallet connection path and provider selection logic (including AA bypass) affect authentication and transaction signing for EVM users; scope is limited to an optional connector and demo wiring.

Overview
Adds a Base Account EVM external connector (v11) using @base-org/account, mirroring the existing Coinbase connector pattern: init via createBaseAccountSDK, connect with eth_requestAccounts, and chain switch/add handling.

SDK surface: @web3auth/no-modal exposes baseAccountConnector and types; @web3auth/modal re-exports it from a new ./connectors entry (alongside coinbase). @base-org/account is an optional peer on modal and no-modal.

Wallet / AA behavior: Registers WALLET_CONNECTORS.BASE_ACCOUNT (base-account) with login param typing. Account-abstraction wrapping is skipped when the active connector is Base Account, since it is already a smart-account style provider.

Demo: vue-app-new can select base-account-connector, imports connectors from @web3auth/modal/connectors, fixes the connector loop off-by-one, and runs the connectors watcher with immediate: true. Vite pre-bundles @base-org/account and @coinbase/wallet-sdk.

Also bumps workspace packages to 11.2.0 and React overrides to 19.2.7, with lockfile updates for the new dependency tree.

Reviewed by Cursor Bugbot for commit 72ec1c4. Bugbot is set up for automated code reviews on this repo. Configure here.

@yashovardhan yashovardhan requested review from a team as code owners July 1, 2026 06:58
@vercel

vercel Bot commented Jul 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web3auth-web Ready Ready Preview, Comment Jul 2, 2026 11:20am

Request Review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 068422a. Configure here.

Comment thread packages/no-modal/src/connectors/base-account-connector/baseAccountConnector.ts Outdated
Comment thread packages/modal/src/connectors/index.ts
Comment thread packages/no-modal/src/connectors/base-account-connector/baseAccountConnector.ts Outdated
Comment thread packages/no-modal/src/connectors/base-account-connector/baseAccountConnector.ts Outdated
lwin-kyaw
lwin-kyaw previously approved these changes Jul 2, 2026
Comment thread packages/no-modal/src/connectors/index.ts Outdated
@chaitanyapotti chaitanyapotti merged commit 649bbd2 into master Jul 2, 2026
7 checks passed
@chaitanyapotti chaitanyapotti deleted the base-account-connector branch July 2, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants