Fix effects for inexactly imported functions#8823
Open
stevenfontanella wants to merge 1 commit into
Open
Conversation
stevenfontanella
added a commit
that referenced
this pull request
Jun 10, 2026
Even if the visitor takes a mutable pointer param e.g. `Function*`, it still works since the pointers aren't a member of a the `Module` itself but stored in a separate unique_ptr. Also use a forwarding reference for `visitor` to avoid copies. For use in #8823.
stevenfontanella
force-pushed
the
import-global-effects
branch
from
4d600b1 to
2941d16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #8807 (review). When a function is imported inexactly, it may be downcasted to any of its subtypes. So a call_ref to $sub needs to include effects from an import of type $super. This isn't needed for ref.func on a defined (non-imported) function because we know its exact type in that case, and ditto for exact imports.
Part of #8615.