navigator.mediaCapabilities wrapper should not become GC-collectable …#1687
Open
Conversation
…before its navigator object https://bugs.webkit.org/show_bug.cgi?id=315684 Reviewed by Ryosuke Niwa. navigator.mediaCapabilities wrapper should not become GC-collectable before its navigator object. The MediaCapabilities interface is annotated [SameObject] in the spec: https://www.w3.org/TR/media-capabilities/#idl-index It means that navigator.mediaCapabilities must return the same object on every access. See: #1678 Original author: Andrzej Surdej (https://github.com/asurdej-comcast) Updated existing LayoutTest with mediaCapabilities case. * LayoutTests/fast/dom/navigator-property-gc-after-frame-detach-expected.txt: * LayoutTests/fast/dom/navigator-property-gc-after-frame-detach.html: * Source/WebCore/Modules/mediacapabilities/MediaCapabilities.cpp: (WebCore::MediaCapabilities::MediaCapabilities): (WebCore::MediaCapabilities::navigator): * Source/WebCore/Modules/mediacapabilities/MediaCapabilities.h: (WebCore::MediaCapabilities::create): * Source/WebCore/Modules/mediacapabilities/MediaCapabilities.idl: * Source/WebCore/Modules/mediacapabilities/NavigatorMediaCapabilities.cpp: (WebCore::NavigatorMediaCapabilities::NavigatorMediaCapabilities): (WebCore::NavigatorMediaCapabilities::from): * Source/WebCore/Modules/mediacapabilities/NavigatorMediaCapabilities.h: * Source/WebCore/Modules/mediacapabilities/WorkerNavigatorMediaCapabilities.cpp: (WebCore::WorkerNavigatorMediaCapabilities::WorkerNavigatorMediaCapabilities): (WebCore::WorkerNavigatorMediaCapabilities::from): * Source/WebCore/Modules/mediacapabilities/WorkerNavigatorMediaCapabilities.h: Canonical link: https://commits.webkit.org/315088@main
pgorszkowski-igalia
force-pushed
the
pgorszkowski/2.46/navigator-mediaCapabilities-wrapper-should-not-become-GC-collectable-before-its-navigator-object
branch
from
8739601 to
4d0202a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…before its navigator object
https://bugs.webkit.org/show_bug.cgi?id=315684
Reviewed by Ryosuke Niwa.
navigator.mediaCapabilities wrapper should not become GC-collectable before its navigator object. The MediaCapabilities interface is annotated [SameObject] in the spec: https://www.w3.org/TR/media-capabilities/#idl-index It means that navigator.mediaCapabilities must return the same object on every access.
See: #1678
Original author: Andrzej Surdej (https://github.com/asurdej-comcast)
Updated existing LayoutTest with mediaCapabilities case.
(WebCore::MediaCapabilities::navigator):
Canonical link: https://commits.webkit.org/315088@main
4d0202a