[GStreamer] Video element with canvas captureStream source should not…#1688
Open
pgorszkowski-igalia wants to merge 1 commit into
Conversation
… use holepunch rendering https://bugs.webkit.org/show_bug.cgi?id=316297 Reviewed by Philippe Normand. Introduce a dedicated Canvas device type in CaptureDevice::DeviceType to distinguish CanvasCaptureMediaStreamTrack sources from Camera sources. Update all switch statements and type checks across the mediastream stack to handle Canvas as a video type. Disable GStreamer hole-punch rendering for canvas-captured streams since they render via a different path. No new tests. There is: ManualTests/mediastream/mediastream-canvas-to-video.html, which can be used to test this change. It should behave in the same way with: WEBKIT_GST_HOLE_PUNCH_QUIRK=fake and without it. * Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp: (WebCore::CanvasCaptureMediaStreamTrack::Source::Source): * Source/WebCore/Modules/mediastream/CanvasCaptureMediaStreamTrack.h: * Source/WebCore/Modules/mediastream/MediaDeviceInfo.cpp: (WebCore::toMediaDeviceInfoKind): * Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp: (WebCore::MediaStreamTrack::captureState): * Source/WebCore/dom/Document.cpp: (WebCore::updateCaptureSourceToPageMutedState): * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::isHolePunchRenderingEnabled const): * Source/WebCore/platform/mediastream/CaptureDevice.h: * Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp: (WebCore::toSourceType): * Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp: (WebCore::GStreamerCaptureDeviceManager::refreshCaptureDevices): * Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.cpp: Canonical link: https://commits.webkit.org/315089@main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… use holepunch rendering
https://bugs.webkit.org/show_bug.cgi?id=316297
Reviewed by Philippe Normand.
Introduce a dedicated Canvas device type in CaptureDevice::DeviceType to distinguish CanvasCaptureMediaStreamTrack sources from Camera sources. Update all switch statements and type checks across the mediastream stack to handle Canvas as a video type.
Disable GStreamer hole-punch rendering for canvas-captured streams since they render via a different path.
No new tests.
There is: ManualTests/mediastream/mediastream-canvas-to-video.html, which can be used to test this change. It should behave in the same way with: WEBKIT_GST_HOLE_PUNCH_QUIRK=fake and without it.
Canonical link: https://commits.webkit.org/315089@main