Charset: Fix broken test for utf8_decode() fallback.#12147
Closed
dmsnell wants to merge 1 commit into
Closed
Conversation
Detected while fuzz-testing the UTF-8 handling code, this defect meant that the tests were verifying the wrong behavior. Namely, they verified a stringification of ASCII digits, which always converted plainly, when they were meant to test handling of invalid UTF-8 sequences. This patch fixes the test by calling `chr()` on the byte values before concatenating into a big string. Follow-up to: [60950]. Co-Authored-By: Jon Surrell <jonsurrell@git.wordpress.org>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
dmsnell
force-pushed
the
compat/fix-broken-test-for-utf8-decode
branch
from
d909d11 to
372919a
Compare
pento
pushed a commit
that referenced
this pull request
Jun 10, 2026
Detected while fuzz-testing the UTF-8 handling code, this defect meant that the tests were verifying the wrong behavior. Namely, they verified a stringification of ASCII digits, which always converted plainly, when they were meant to test handling of invalid UTF-8 sequences. This patch fixes the test by calling `chr()` on the byte values before concatenating into a big string. Developed in: #12147 Discussed in: https://core.trac.wordpress.org/ticket/65372 Props dmsnell, jonsurrell. Follow-up to: [60950]. See #65372. git-svn-id: https://develop.svn.wordpress.org/trunk@62484 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Jun 10, 2026
Detected while fuzz-testing the UTF-8 handling code, this defect meant that the tests were verifying the wrong behavior. Namely, they verified a stringification of ASCII digits, which always converted plainly, when they were meant to test handling of invalid UTF-8 sequences. This patch fixes the test by calling `chr()` on the byte values before concatenating into a big string. Developed in: WordPress/wordpress-develop#12147 Discussed in: https://core.trac.wordpress.org/ticket/65372 Props dmsnell, jonsurrell. Follow-up to: [60950]. See #65372. Built from https://develop.svn.wordpress.org/trunk@62484 git-svn-id: http://core.svn.wordpress.org/trunk@61765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: Core-65372
Detected while fuzz-testing the UTF-8 handling code, this defect meant that the tests were verifying the wrong behavior. Namely, they verified a stringification of ASCII digits, which always converted plainly, when they were meant to test handling of invalid UTF-8 sequences.
This patch fixes the test by calling
chr()on the byte values before concatenating into a big string.Follow-up to: [60950].