control-v1: add missing type to conflationEnabled#3472
Open
surminus wants to merge 1 commit into
Open
Conversation
I generate the Terraform provider schemas from this spec, and tfplugingen-openapi silently skips any property that has no type. conflationEnabled in the three namespace schemas has a default, description and example but no type, so the attribute vanishes from the generated schema without any error. I checked the rest of the spec and these three are the only untyped properties. The provider currently carries this fix as a local patch on its vendored copy (codegen/spec-fixes.patch), which we can drop once this lands. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I generate the Terraform provider schemas from this spec, and tfplugingen-openapi silently skips any property that has no type.
conflationEnabledin the three namespace schemas (namespace_post,namespace_patch,namespace_response) has a default, description and example but notype, so the attribute vanishes from the generated schema without any error. I scanned the rest of the spec and these three are the only untyped properties in the file.The Terraform provider currently carries this fix as a local patch on its vendored copy of the spec (
codegen/spec-fixes.patch), which I can drop once this lands.🤖 Generated with Claude Code