Skip to content

Detect KISA copyright holder with parenthesized expansion#5133

Open
gaoflow wants to merge 2 commits into
aboutcode-org:developfrom
gaoflow:fix-5125-kisa-holder-detection
Open

Detect KISA copyright holder with parenthesized expansion#5133
gaoflow wants to merge 2 commits into
aboutcode-org:developfrom
gaoflow:fix-5125-kisa-holder-detection

Conversation

@gaoflow

@gaoflow gaoflow commented Jun 19, 2026

Copy link
Copy Markdown

Fixes #5125.

Summary

  • Treat an uppercase acronym followed by an opening parenthesized expansion, such as KISA(Korea, as a proper-name token before the broader middle-parenthesis JUNK rule.
  • Add a data-driven copyright fixture for Copyright (c) 2007 KISA(Korea Information Security Agency).
  • Add my name to AUTHORS.rst as requested by the contribution guide.

Tests

  • .venv/bin/python -m py_compile src/cluecode/copyrights.py tests/cluecode/test_copyrights.py
  • git diff --check
  • Targeted detect_copyrights_from_lines() check for the KISA sample, expecting both the full copyright and holder.
  • pytest tests/cluecode/test_copyrights.py -k kisa_seed_local --test-suite all -q passes locally when using a pure-text numbered_text_lines shim; the full local ScanCode test environment is blocked by missing libmagic on this macOS arm64 setup.

AI assistance was used under my direction.

gaoflow added 2 commits June 19, 2026 08:19
Signed-off-by: Vincent Gao <gaobing1230@gmail.com>
Signed-off-by: Vincent Gao <gaobing1230@gmail.com>
@gaoflow gaoflow force-pushed the fix-5125-kisa-holder-detection branch from a8ee21a to 5eea338 Compare June 20, 2026 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression in detection of a copyright statement

1 participant