Detect KISA copyright holder with parenthesized expansion#5133
Open
gaoflow wants to merge 2 commits into
Open
Conversation
Signed-off-by: Vincent Gao <gaobing1230@gmail.com>
Signed-off-by: Vincent Gao <gaobing1230@gmail.com>
a8ee21a to
5eea338
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5125.
Summary
KISA(Korea, as a proper-name token before the broader middle-parenthesis JUNK rule.Copyright (c) 2007 KISA(Korea Information Security Agency).AUTHORS.rstas requested by the contribution guide.Tests
.venv/bin/python -m py_compile src/cluecode/copyrights.py tests/cluecode/test_copyrights.pygit diff --checkdetect_copyrights_from_lines()check for the KISA sample, expecting both the full copyright and holder.pytest tests/cluecode/test_copyrights.py -k kisa_seed_local --test-suite all -qpasses locally when using a pure-textnumbered_text_linesshim; the full local ScanCode test environment is blocked by missinglibmagicon this macOS arm64 setup.AI assistance was used under my direction.