Propagate (atespace/actor_id) to atelet.#373
Open
Julian Gutierrez Oschmann (juli4n) wants to merge 1 commit into
Open
Propagate (atespace/actor_id) to atelet.#373Julian Gutierrez Oschmann (juli4n) wants to merge 1 commit into
Julian Gutierrez Oschmann (juli4n) wants to merge 1 commit into
Conversation
This fixes an issue where atelet/ateom will clash the state of actors with same ID within different atespaces. Once substrate resources get UIDs, we should revisit the way atelet / ateom does the bookkeeping and check in which cases it should use UID instead of (atespace,actor_id).
Julian Gutierrez Oschmann (juli4n)
requested review from
Haven Xia (HavenXia) and
Tim Hockin (thockin)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where atelet/ateom will clash the state of actors with same ID within different atespaces.
Once substrate resources get UIDs, we should revisit the way atelet / ateom does the bookkeeping and check in which cases it should use UID instead of (atespace,actor_id).