Skip to content

Improve environment printing format#101

Open
lemonez wants to merge 7 commits into
developfrom
improve-env-print-format
Open

Improve environment printing format#101
lemonez wants to merge 7 commits into
developfrom
improve-env-print-format

Conversation

@lemonez

@lemonez lemonez commented Jul 1, 2021

Copy link
Copy Markdown
Contributor

DEV-331 - making env-listing output more user friendly

@zeryx is there a case when the environments response comes back as empty list? I've added some code for sorting the environments but I didn't add any error handling for this case.

@lemonez

lemonez commented Jul 1, 2021

Copy link
Copy Markdown
Contributor Author

oops broke the test

@lemonez lemonez closed this Jul 1, 2021
@lemonez lemonez reopened this Jul 1, 2021
@lemonez

lemonez commented Jul 1, 2021

Copy link
Copy Markdown
Contributor Author

@zeryx please see comment in initial PR description

@lemonez lemonez marked this pull request as ready for review July 12, 2021 15:19
@lemonez

lemonez commented Jul 12, 2021

Copy link
Copy Markdown
Contributor Author

hey @zeryx I forgot this was still a draft PR. please have a look when able.

@zeryx zeryx self-requested a review July 12, 2021 15:31

@zeryx zeryx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like your test modifications fail, not sure if you're able to access gitlab; in any case here's the failure message:

self = <Test.CLI_test.CLITest testMethod=test_get_environment>
    def test_get_environment(self):
    	result = CLI().get_environment_by_language("python2",self.client)
    	print(result)
    	if("error" in result):
    		print(result)
>   	self.assertTrue(result is not None and "Python 2.7" in result)
E    AssertionError: False is not true
Test/CLI_test.py:180: AssertionError
----------------------------- Captured stdout call -----------------------------
['Display Name                                  Specification ID                        ', '********************************************************************************', 'Python 2.7                                    f626effa-e519-431e-9d7a-0d3a7563ae1e    ', 'Python 2.7 + GPU support                      faf81400-eb15-4f64-81c0-3d4ed7181e77    ']
_________________________ CLITest.test_list_languages __________________________
self = <Test.CLI_test.CLITest testMethod=test_list_languages>
    def test_list_languages(self):
    	result = CLI().list_languages(self.client)
    	if("error" in result[0]):
    		print(result)
>   	self.assertTrue(result is not None and "anaconda3" in result[1])
E    AssertionError: False is not true
Test/CLI_test.py:186: AssertionError

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants