You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Amoro uses deprecated Iceberg configuration and thread-pool APIs, while the planning and commit pool scope is not explicit enough for future process-specific scan/plan pools.
getThreadPool is called from the scan path through IcebergTableFileScanHelper.scan(). Since production standalone optimizers do not call IcebergThreadPools.init(), this fallback can be executed once per scan. The warning is currently logged unconditionally, which may cause significant log I/O and CPU overhead under load, despite the Javadoc stating that the warning is logged only once per pool.
Could we restore per-pool warning deduplication, for example with ConcurrentHashMap.newKeySet(), or otherwise rate-limit this log? Please also add a regression test to verify that repeated fallback calls emit the warning only once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Amoro uses deprecated Iceberg configuration and thread-pool APIs, while the planning and commit pool scope is not explicit enough for future process-specific scan/plan pools.
Close #4269.
Brief change log
SystemPropertiesandThreadPools.newWorkerPool()usage.How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
./mvnw -pl amoro-ams -am -DskipTests compileDocumentation