Allow deploy of VRs on dedicated resources by GaOrtiga · Pull Request #9531 · apache/cloudstack

GaOrtiga · 2024-08-14T16:08:48Z

Description

Currently, it is not possible to deploy VRs on dedicated resources, even if they are dedicated to the domain in which the VR will be created.

A new global configuration allowRoutersOnDedicatedResources has been created to allow VRs to be deployed on hosts, clusters, pods and zones that are dedicated to their respective domains.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

How Has This Been Tested?

With the configuration marked as true:

I dedicated resources to the domain in which the VRs would be deployd and verified that the deploy worked normally.
I dedicated resources to an account in that domain and verified that I could not deploy VRs on these resources.
I dedicated resources to a different domain and verified that I could not deploy VRs on these resources.

I marked the configuration as false and verified that I could not deploy VRs on any of the dedicated resources.

DaanHoogland · 2025-02-06T09:07:00Z

@blueorangutan package

blueorangutan · 2025-02-06T09:08:04Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2025-02-06T09:55:31Z

Codecov Report

❌ Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.76%. Comparing base (3166e64) to head (1bdb771).
⚠️ Report is 75 commits behind head on main.

Files with missing lines	Patch %	Lines
...n/java/com/cloud/capacity/dao/CapacityDaoImpl.java	50.00%	1 Missing and 1 partial ⚠️
...rc/main/java/com/cloud/deploy/FirstFitPlanner.java	87.50%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #9531      +/-   ##
============================================
+ Coverage     18.01%   18.76%   +0.75%     
- Complexity    16607    17974    +1367     
============================================
  Files          6029     6160     +131     
  Lines        542160   552576   +10416     
  Branches      66451    67347     +896     
============================================
+ Hits          97682   103709    +6027     
- Misses       433461   437459    +3998     
- Partials      11017    11408     +391

Flag	Coverage Δ
uitests	`3.53% <ø> (+<0.01%)`	⬆️
unittests	`19.96% <76.92%> (+0.78%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2025-02-06T10:30:36Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12358

nicoschmdt · 2025-02-14T14:39:58Z

Hey @DaanHoogland, could we run the CI on this PR?

DaanHoogland · 2025-02-15T14:03:49Z

@blueorangutan test

blueorangutan · 2025-02-15T14:06:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-02-16T07:04:47Z

[SF] Trillian test result (tid-12421)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 58187 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9531-t12421-kvm-ol8.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_11_isolated_network_with_dynamic_routed_mode	`Error`	2.29	test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode	`Error`	1.41	test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode	`Error`	1.41	test_ipv4_routing.py
test_12_start_vm_multiple_volumes_allocated	`Error`	20.01	test_vm_life_cycle.py

github-actions · 2025-05-02T08:39:43Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

nicoschmdt · 2025-05-06T20:22:26Z

@blueorangutan package

blueorangutan · 2025-05-06T20:24:04Z

@nicoschmdt a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-05-06T21:28:52Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13280

github-actions · 2025-07-15T11:11:38Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

rajujith · 2026-01-13T05:40:12Z

@GaOrtiga Since this is for the 4.22.1 release, could you retarget the PR to the 4.22 branch?

GaOrtiga · 2026-03-12T11:46:47Z

@GaOrtiga Since this is for the 4.22.1 release, could you retarget the PR to the 4.22 branch?

Hi, @rajujith, when testing this I had some ideas of possible improvements, which should be added to this PR, however, I have other obligations which take precedence over this PR, so I will leave it on draft until I can work on it again. When I'm back to working on it, I'll change it to the correct branch.

Thank you.

sureshanaparti · 2026-04-21T05:58:25Z

@blueorangutan package

blueorangutan · 2026-04-21T06:00:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-04-21T06:15:37Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 17561

sureshanaparti · 2026-04-24T11:01:48Z

@GaOrtiga can you check/fix the build failure.

winterhazel · 2026-05-25T12:58:39Z

@GaOrtiga could you have a look at the conflicts?

GaOrtiga · 2026-05-25T18:12:28Z

@rajujith @sureshanaparti @winterhazel

Sorry for the delay, this was on my backlog.

I had to to some adjustments to address some use cases that were brought up, but now its ready for review/testing.

GaOrtiga · 2026-06-01T14:13:34Z

@blueorangutan package

blueorangutan · 2026-06-01T14:14:04Z

@GaOrtiga a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-06-01T15:20:39Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18113

DaanHoogland

clgtm, (one style remark)

…Impl.java Co-authored-by: dahn <daan.hoogland@gmail.com>

DaanHoogland reviewed Aug 16, 2024

View reviewed changes

Comment thread engine/schema/src/main/java/com/cloud/capacity/dao/CapacityDao.java Outdated

nicoschmdt force-pushed the deploy_vr_dedicated_resources branch from 5da9945 to 7b05daf Compare February 5, 2025 16:13

boring-cyborg Bot added the component:api label Feb 5, 2025

JoaoJandre approved these changes Feb 19, 2025

View reviewed changes

nicoschmdt self-assigned this Feb 19, 2025

github-actions Bot added the status:has-conflicts label May 2, 2025

nicoschmdt force-pushed the deploy_vr_dedicated_resources branch from 7b05daf to e15e366 Compare May 6, 2025 20:21

github-actions Bot removed the status:has-conflicts label May 6, 2025

DaanHoogland added this to the 4.21.0 milestone May 7, 2025

sureshanaparti added this to Apache CloudStack 4.21.0 Jun 5, 2025

sureshanaparti moved this to In Progress in Apache CloudStack 4.21.0 Jun 5, 2025

github-actions Bot added the status:has-conflicts label Jul 15, 2025

weizhouapache modified the milestones: 4.21.0, 4.22.0 Aug 29, 2025

sureshanaparti added this to Apache CloudStack 4.22.0 Aug 29, 2025

sureshanaparti removed this from Apache CloudStack 4.21.0 Aug 29, 2025

sureshanaparti moved this to In Progress in Apache CloudStack 4.22.0 Aug 29, 2025

harikrishna-patnala removed this from Apache CloudStack 4.22.0 Nov 12, 2025

rajujith added this to Apache CloudStack 4.22.1 Jan 5, 2026

sureshanaparti moved this to In Progress in Apache CloudStack 4.22.1 Jan 7, 2026

GaOrtiga and others added 2 commits April 20, 2026 09:35

allow deploy of VRs on dedicated resources

9e19ab3

Move configuration to Planner hierarchy

42c5625

GaOrtiga force-pushed the deploy_vr_dedicated_resources branch from e15e366 to 2bc25d1 Compare April 20, 2026 17:57

github-actions Bot removed the status:has-conflicts label Apr 21, 2026

sureshanaparti removed this from Apache CloudStack 4.22.1 Apr 24, 2026

sureshanaparti modified the milestones: 4.22.1, 4.23.0 Apr 24, 2026

allow deploy when resource is dedicated to account

e2197f0

GaOrtiga force-pushed the deploy_vr_dedicated_resources branch from 2bc25d1 to e2197f0 Compare May 25, 2026 17:27

fix tests

8b20abe

GaOrtiga marked this pull request as ready for review May 25, 2026 18:13

DaanHoogland reviewed Jun 11, 2026

View reviewed changes

Comment thread engine/schema/src/main/java/com/cloud/capacity/dao/CapacityDaoImpl.java Outdated

DaanHoogland reviewed Jun 11, 2026

View reviewed changes

Comment thread engine/schema/src/main/java/com/cloud/capacity/dao/CapacityDaoImpl.java Outdated

DaanHoogland approved these changes Jun 11, 2026

View reviewed changes

GaOrtiga and others added 2 commits June 11, 2026 07:27

Update engine/schema/src/main/java/com/cloud/capacity/dao/CapacityDao…

e35c299

…Impl.java Co-authored-by: dahn <daan.hoogland@gmail.com>

Update engine/schema/src/main/java/com/cloud/capacity/dao/CapacityDao…

1bdb771

…Impl.java Co-authored-by: dahn <daan.hoogland@gmail.com>

Conversation

GaOrtiga commented Aug 14, 2024

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

How Has This Been Tested?

Uh oh!

Uh oh!

DaanHoogland commented Feb 6, 2025

Uh oh!

blueorangutan commented Feb 6, 2025

Uh oh!

codecov Bot commented Feb 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Feb 6, 2025

Uh oh!

nicoschmdt commented Feb 14, 2025

Uh oh!

DaanHoogland commented Feb 15, 2025

Uh oh!

blueorangutan commented Feb 15, 2025

Uh oh!

blueorangutan commented Feb 16, 2025

Uh oh!

github-actions Bot commented May 2, 2025

Uh oh!

nicoschmdt commented May 6, 2025

Uh oh!

blueorangutan commented May 6, 2025

Uh oh!

blueorangutan commented May 6, 2025

Uh oh!

github-actions Bot commented Jul 15, 2025

Uh oh!

rajujith commented Jan 13, 2026

Uh oh!

GaOrtiga commented Mar 12, 2026

Uh oh!

sureshanaparti commented Apr 21, 2026

Uh oh!

blueorangutan commented Apr 21, 2026

Uh oh!

blueorangutan commented Apr 21, 2026

Uh oh!

sureshanaparti commented Apr 24, 2026

Uh oh!

winterhazel commented May 25, 2026

Uh oh!

GaOrtiga commented May 25, 2026

Uh oh!

GaOrtiga commented Jun 1, 2026

Uh oh!

blueorangutan commented Jun 1, 2026

Uh oh!

blueorangutan commented Jun 1, 2026

Uh oh!

Uh oh!

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

codecov Bot commented Feb 6, 2025 •

edited

Loading