Skip to content

Set length in INVOKEDYNAMIC constructor#521

Merged
garydgregory merged 1 commit into
apache:masterfrom
rootvector2:invokedynamic-constructor-length
Jul 13, 2026
Merged

Set length in INVOKEDYNAMIC constructor#521
garydgregory merged 1 commit into
apache:masterfrom
rootvector2:invokedynamic-constructor-length

Conversation

@rootvector2

Copy link
Copy Markdown
Contributor

found while checking instruction getLength() against dump(): the INVOKEDYNAMIC(int) constructor never sets its length, so a generated invokedynamic reports 3 while dump() writes 5 bytes and InstructionList.setPositions() then places every following instruction 2 bytes too low; mirror the sibling INVOKEINTERFACE/MULTIANEWARRAY constructors (and this class's own initFromFile) by calling setLength(5).

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

The constructor never set the length, so a generated invokedynamic reported getLength() 3 while dump() writes 5 bytes, shifting the offsets of every following instruction in InstructionList.setPositions(). Match INVOKEINTERFACE, MULTIANEWARRAY and this class's own initFromFile.
@garydgregory garydgregory changed the title set length in INVOKEDYNAMIC constructor Set length in INVOKEDYNAMIC constructor Jul 13, 2026
@garydgregory
garydgregory merged commit 3a49a2d into apache:master Jul 13, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants