Validate u1 count bound in INVOKEINTERFACE and MULTIANEWARRAY#523
Merged
Conversation
garydgregory
requested changes
Jul 15, 2026
garydgregory
left a comment
Member
There was a problem hiding this comment.
Hello @rootvector2
Please skip the new test class into 2: One for each main class modified.
Contributor
Author
|
Done. Split it into one class per instruction: the |
garydgregory
added a commit
that referenced
this pull request
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
countoperand ofinvokeinterfaceand thedimensionsoperand ofmultianewarrayare each a u1 (1-255), butINVOKEINTERFACE(int, int)andMULTIANEWARRAY(int, short)only check the lower bound (nargs < 1/dimensions < 1) while theirdump()writes the field without.writeByte(...). A value in 256-32767 is accepted and returned bygetCount()/getDimensions(), but truncated to its low 8 bits on dump, so the emitted instruction carries a different count than requested (e.g.260is written as4). Found while sweeping the generation-sidewriteBytesites after #506 fixed the u2 index setters. Adds the matching> Const.MAX_BYTEguard to both constructors;IINC/RET/LDCalready pick a wider form so they are unaffected.mvn; that'smvnon the command line by itself.