Skip trailing delimiter on comment lines in printComment#623
Merged
garydgregory merged 1 commit intoJul 16, 2026
Conversation
garydgregory
changed the title
Member
|
Good find @rootvector2 ; merged 🚀 |
garydgregory
added a commit
that referenced
this pull request
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
printCommentcloses each comment line withprintln(), which appends the trailing delimiter whensetTrailingDelimiter(true)is set. So a multi-line comment prints# line1,/# line2,and the parser reads that delimiter back as part of the comment text. Found round-tripping comments through a printer with the trailing delimiter enabled.Close comment lines with the record separator only. The trailing delimiter is documented as following the last value of a record, and a comment is not a record, so the record and header paths keep calling
println()and stay unchanged.